Comments on: Binary search an array in JavaScript

By: bob

bob — Thu, 21 Apr 2011 18:42:48 +0000

the “continue”s are unnecessary if you just use if/else

if (comparison < 0)
low = i + 1;
else if (comparison > 0)
high = i – 1;
else
return i;

By: Jim Hawk III

Jim Hawk III — Mon, 05 Jul 2010 23:44:57 +0000

Oh, one more thing:

Array.prototype.binarySearch = function binarySearch(find, comparator)

is redundant.

Array.prototype.binarySearch = function (find, comparator)

works just fine.

By: Jim Hawk III

Jim Hawk III — Mon, 05 Jul 2010 23:39:03 +0000

Well, since I’ve already tossed my hat in, it occurs to me that the return for a failed search should be -1, which stays with the pattern established by String.indexOf. Since null is not a number, and every other possible result of the function is a number, you really ought to stay with numbers rather than tossing in null.

By: Jim Hawk III

Jim Hawk III — Mon, 05 Jul 2010 23:33:48 +0000

i = parseInt((low + high) / 2, 10); ????

What’s wrong with i = Math.floor((low + high) / 2); ? parseInt has to turn the math result to a string, and then back to a number again, which wastes a lot of time.

By: John

John — Thu, 08 Apr 2010 14:24:27 +0000

There is example of using search array functionality

http://vitana-group.com/article/javascript-dhtml/Iterator

as described here it supports any array items type, even array of json objects
Looks good

By: noah

noah — Wed, 21 Jan 2009 15:47:27 +0000

Should the title be “Binary *search* an array in JavaScript”?